Skip to content

Dynamic Variables and Improved Benchmark files #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 24, 2020

Conversation

JacobMGEvans
Copy link
Contributor

  • Modified the make file to specifically execute sh on the run file which is set to be a bash file ecosystem.
  • Set the environments in the bash run file utilizing a .env file for PORT, however, a fallback PORT can also be added. (waiting on an opinion if not necessary then-current configurations, meaning .env file needed for benchmarking should be added to documentation)
  • based on @niftylettuce suggestion used the ladjs/env for the server.js file to be able to use both the .env and the bash file exported variables to local environment.

resolves #56

JacobMGEvans and others added 8 commits February 6, 2020 21:18

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Update Local

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
…ass in FACTOR and USE_MIDDLEWARE

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
- Improving the output could be helpful
- Kept the order in the makefile

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@JacobMGEvans
Copy link
Contributor Author

I created an issue for the breaking build. I noticed Travis was checking support for very old versions of Node which was failing on the test dependency Chokidar (they are using async/await) which is supported in a late version of Node 7 and after.
#61 @niftylettuce

@niftylettuce niftylettuce merged commit 1940ec9 into koajs:master Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use an alternative to hardcoded 3333 in Bench tests
2 participants