From e74457d49af59fba87ea5c0451110624d901805a Mon Sep 17 00:00:00 2001 From: Piotr Kuczynski Date: Fri, 28 May 2021 12:22:59 +0200 Subject: [PATCH 1/2] Fix jsdoc type for options.proxyIpHeader --- lib/application.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/application.js b/lib/application.js index 6849d73fd..ef59511fd 100644 --- a/lib/application.js +++ b/lib/application.js @@ -41,7 +41,7 @@ module.exports = class Application extends Emitter { * @param {string[]} [options.keys] Signed cookie keys * @param {boolean} [options.proxy] Trust proxy headers * @param {number} [options.subdomainOffset] Subdomain offset - * @param {boolean} [options.proxyIpHeader] proxy ip header, default to X-Forwarded-For + * @param {string} [options.proxyIpHeader] proxy ip header, default to X-Forwarded-For * @param {boolean} [options.maxIpsCount] max ips read from proxy ip header, default to 0 (means infinity) * */ From 14dea5a806f98932790c88bc946be234ecba495b Mon Sep 17 00:00:00 2001 From: Piotr Kuczynski Date: Fri, 28 May 2021 12:28:54 +0200 Subject: [PATCH 2/2] Update application.js --- lib/application.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/application.js b/lib/application.js index ef59511fd..dc3a407a8 100644 --- a/lib/application.js +++ b/lib/application.js @@ -41,8 +41,8 @@ module.exports = class Application extends Emitter { * @param {string[]} [options.keys] Signed cookie keys * @param {boolean} [options.proxy] Trust proxy headers * @param {number} [options.subdomainOffset] Subdomain offset - * @param {string} [options.proxyIpHeader] proxy ip header, default to X-Forwarded-For - * @param {boolean} [options.maxIpsCount] max ips read from proxy ip header, default to 0 (means infinity) + * @param {string} [options.proxyIpHeader] Proxy IP header, defaults to X-Forwarded-For + * @param {number} [options.maxIpsCount] Max IPs read from proxy IP header, default to 0 (means infinity) * */