Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jsdoc types for constructor #1541

Merged
merged 2 commits into from Aug 18, 2021
Merged

Conversation

pkuczynski
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #1541 (14dea5a) into master (698ce0a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1541   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          489       489           
  Branches       136       136           
=========================================
  Hits           489       489           
Impacted Files Coverage Δ
lib/application.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 698ce0a...14dea5a. Read the comment docs.

@pkuczynski pkuczynski changed the title Fix jsdoc type for options.proxyIpHeader Fix jsdoc types for constructor May 28, 2021
Copy link
Member

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 💯

@jonathanong jonathanong merged commit 689c98d into koajs:master Aug 18, 2021
jonathanong pushed a commit that referenced this pull request Aug 18, 2021
* Fix jsdoc type for options.proxyIpHeader

* Update application.js
jonathanong pushed a commit that referenced this pull request Aug 18, 2021
* Fix jsdoc type for options.proxyIpHeader

* Update application.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants