Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade koa-convert dependency to ^2.0.0 #1535

Merged
merged 1 commit into from Aug 18, 2021

Conversation

atombrenner
Copy link

fix issue #1534

@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #1535 (904f8ab) into master (eb51cf5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1535   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          489       489           
  Branches       136       136           
=========================================
  Hits           489       489           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb51cf5...904f8ab. Read the comment docs.

@miwnwski
Copy link
Member

I agree it should be upgraded (and removed in next) but this would result in a breaking change (I don't really remember why convert got bumped major, maybe you can enlighten me if you recently checked it out?).

This will have to wait to next version of Koa, though any possible next Koa dependency would actually remove this dependency.

@atombrenner
Copy link
Author

(I don't really remember why convert got bumped major, maybe you can enlighten me if you recently checked it out?).

As far as I can see, the change is the dependency upgrade of koa-compose@3.2.1 to koa-compose@4.1.0 plus some more cosmetic refactorings.

@miwnwski
Copy link
Member

Well in that case, it LGTM!

@miwnwski
Copy link
Member

miwnwski commented May 18, 2021

Holding off merge a little to give others some time to chime in

Copy link
Member

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm +1

whisper: we must move quickly to work on next release of Koa. #1508

@jonathanong jonathanong changed the base branch from master to v2.x August 18, 2021 04:55
@jonathanong jonathanong merged commit 7e532d2 into koajs:v2.x Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants