New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade koa-convert dependency to ^2.0.0 #1535
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1535 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 489 489
Branches 136 136
=========================================
Hits 489 489 Continue to review full report at Codecov.
|
I agree it should be upgraded (and removed in next) but this would result in a breaking change (I don't really remember why convert got bumped major, maybe you can enlighten me if you recently checked it out?). This will have to wait to next version of Koa, though any possible next Koa dependency would actually remove this dependency. |
As far as I can see, the change is the dependency upgrade of koa-compose@3.2.1 to koa-compose@4.1.0 plus some more cosmetic refactorings. |
Well in that case, it LGTM! |
Holding off merge a little to give others some time to chime in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm +1
whisper: we must move quickly to work on next release of Koa. #1508
fix issue #1534