Fix grammar mistake #1527
Merged
Fix grammar mistake #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1527 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 489 489
Branches 136 136
=========================================
Hits 489 489 Continue to review full report at Codecov.
|
8enSmith
reviewed
Mar 24, 2021
docs/api/index.md
Outdated
Comment on lines
49
to
50
| the `x-response-time` and `logging` middleware to mark when the request started, then continues | ||
| to yield control through the response middleware. When a middleware invokes `next()` |
There was a problem hiding this comment.
suggestion: This could be further simplified to "...mark when the request started, then yields control through the response middleware."
There was a problem hiding this comment.
Even better, @8enSmith ! Thank you
jonathanong
pushed a commit
that referenced
this pull request
Aug 18, 2021
* Fix grammar mistake * Simplify correction
jonathanong
pushed a commit
that referenced
this pull request
Aug 18, 2021
* Fix grammar mistake * Simplify correction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a grammar mistake written on Koa's doc