fix: make ESM transpiled CommonJS play nice for TS folks, fix #1513 #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miwnwski
force-pushed
the
export-default
branch
from
0beef00
to
4f78703
Compare
Codecov Report
@@ Coverage Diff @@
## master #1518 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 487 489 +2
Branches 136 136
=========================================
+ Hits 487 489 +2
Continue to review full report at Codecov.
|
dead-horse
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a "fix" I guess to allow TS typings to actually work - according to some other people that actually use TS.
I'm going to need confirmation on both its application, and that this doesn't break anything for Koa v2.