Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use single console.error() statement in error handler #1471

Merged
merged 1 commit into from Jun 13, 2020
Merged

Use single console.error() statement in error handler #1471

merged 1 commit into from Jun 13, 2020

Conversation

mpvosseller
Copy link
Contributor

Removes two console.error() statements that take no arguments and appears only to be used for formatting purposes. To maintain the current formatting this adds a \n before and after the logged error message.

This fixes #1470 which reports that console.error() statements with no arguments cause noise in AWS Cloudwatch.

@codecov
Copy link

codecov bot commented Jun 7, 2020

Codecov Report

Merging #1471 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1471      +/-   ##
==========================================
- Coverage   99.38%   99.37%   -0.01%     
==========================================
  Files           4        4              
  Lines         485      483       -2     
  Branches      132      132              
==========================================
- Hits          482      480       -2     
  Partials        3        3              
Impacted Files Coverage Δ
lib/application.js 98.26% <100.00%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ee6584...3187360. Read the comment docs.

@dead-horse dead-horse merged commit 5208c5e into koajs:master Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove two blank error log statements in the default error handler
2 participants