Document response status with empty body #1445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1445 +/- ##
=======================================
Coverage 99.37% 99.37%
=======================================
Files 4 4
Lines 479 479
Branches 128 128
=======================================
Hits 476 476
Partials 3 3 Continue to review full report at Codecov.
|
dead-horse
approved these changes
Apr 18, 2020
|
Thanks @dead-horse. And thanks for Koa.js which is great. |
madarche
deleted the
feat-explicitly-document-response-status-with-empty-body
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is a very simple addition to the docs to explicitly document how to return a status code different than 400 when one doesn't set any body in the response.
As a new Koa user (coming from Express) this is a topic that has puzzled me at the beginning. Of course after having used Koa for a little while, the answer seems obvious. But I believe this addition will speed up even more the learning curve.