Updating context.md with the latest cookies opts #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copying from the source document of the cookies module. In particular, adding in documentation of the sameSite attribute
The cookies source documentation is missing this, but it supports the value of "none" for the sameSite option. passing along this enhancement to koa's documentation
Codecov Report
@@ Coverage Diff @@
## master #1433 +/- ##
=======================================
Coverage 99.37% 99.37%
=======================================
Files 4 4
Lines 479 479
Branches 128 128
=======================================
Hits 476 476
Partials 3 3 Continue to review full report at Codecov.
|
|
Noting that this is especially timely before Feb 4, 2020, because Chrome will be requiring this option be set in situations which require it. https://blog.chromium.org/2019/10/developers-get-ready-for-new.html also, came to the docs with some urgency because this is for a Shopify App |
3imed-jaberi
reviewed
Feb 5, 2020
Co-Authored-By: imed jaberi <imed_jebari@hotmail.fr>
dead-horse
approved these changes
Apr 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying from the source document of the cookies module. In particular, adding in documentation of the sameSite attribute