Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement response.has #1397

Merged
merged 6 commits into from
Oct 14, 2019
Merged

implement response.has #1397

merged 6 commits into from
Oct 14, 2019

Conversation

tinovyatkin
Copy link
Contributor

@tinovyatkin tinovyatkin commented Oct 14, 2019

Implement (and use) response.has to match Node' response.hasHeader

@codecov
Copy link

codecov bot commented Oct 14, 2019

Codecov Report

Merging #1397 into master will decrease coverage by 0.63%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1397      +/-   ##
==========================================
- Coverage     100%   99.36%   -0.64%     
==========================================
  Files           4        4              
  Lines         382      476      +94     
  Branches        0      125     +125     
==========================================
+ Hits          382      473      +91     
- Partials        0        3       +3
Impacted Files Coverage Δ
lib/context.js 100% <ø> (ø) ⬆️
lib/response.js 99.37% <100%> (-0.63%) ⬇️
lib/application.js 98.19% <0%> (-1.81%) ⬇️
lib/request.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66c1593...163456f. Read the comment docs.

@tinovyatkin tinovyatkin changed the title add to docs implement response.has Oct 14, 2019
Copy link
Contributor

@fl0w fl0w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dead-horse dead-horse merged commit d48d88e into koajs:master Oct 14, 2019
@tinovyatkin tinovyatkin deleted the add-response-has branch October 14, 2019 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants