Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce unnecessary variable declarations #1298

Merged
merged 1 commit into from Jan 14, 2019
Merged

Conversation

zhaosaisai
Copy link
Contributor

It is unnecessary to declare res if ctx.writable === false

@codecov
Copy link

codecov bot commented Jan 14, 2019

Codecov Report

Merging #1298 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1298   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files           5       5           
  Lines         393     393           
======================================
  Hits          393     393
Impacted Files Coverage Δ
lib/application.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad91ce2...91f8297. Read the comment docs.

@dead-horse dead-horse merged commit b15115b into koajs:master Jan 14, 2019
kiku-jw pushed a commit to kiku-jw/koa that referenced this pull request Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants