Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1277]: Documentation: response.set(fields) overwrites previous header fields? #1282

Merged
merged 2 commits into from Dec 7, 2018
Merged

[#1277]: Documentation: response.set(fields) overwrites previous header fields? #1282

merged 2 commits into from Dec 7, 2018

Conversation

doug-wade
Copy link
Contributor

Fixes #1277

@codecov
Copy link

codecov bot commented Dec 5, 2018 •
edited

Codecov Report

Merging #1282 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1282   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files           5       5           
  Lines         395     395           
======================================
  Hits          395     395

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 281a04e...1306d10. Read the comment docs.

@fl0w
Copy link
Contributor

fl0w commented Dec 5, 2018

Personally I would somehow add that set "delegates to setHeader which only sets or updates [...]".

Otherwise LGTM

@doug-wade
Copy link
Contributor Author

Thanks for the feedback @fl0w ! I've made the requested changes.

@dead-horse dead-horse merged commit f90e825 into koajs:master Dec 7, 2018
kiku-jw pushed a commit to kiku-jw/koa that referenced this pull request Feb 26, 2019
@doug-wade @kiku-jw
docs: response.set(fields) won't overwrites previous header fields(ko…
63e4e0e 
…ajs#1282)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dead-horse dead-horse dead-horse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doug-wade @fl0w @dead-horse