use the ability of content-type lib directly
#1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we can see the doc of `content-type`: [https://github.com/jshttp/content-type#contenttypeparsereq](https://github.com/jshttp/content-type#contenttypeparsereq), it can deal with the original `req` directly and will also throw the exception when `Content-Type` is missing or unvalid. So in my opinion, we don't need `let type = this.get('Content-Type');` to get the type and `if (!type) return ''` to check if the type is unvalid.
Codecov Report
@@ Coverage Diff @@
## master #1276 +/- ##
======================================
Coverage 100% 100%
======================================
Files 5 5
Lines 395 393 -2
======================================
- Hits 395 393 -2
Continue to review full report at Codecov.
|
dead-horse
approved these changes
Dec 7, 2018
kiku-jw
pushed a commit
to kiku-jw/koa
that referenced
this pull request
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we can see the doc of
content-type: https://github.com/jshttp/content-type#contenttypeparsereq, it can deal with the originalreqdirectly and will also throw TypeError exception whenContent-Typeis missing or invalid. So in my opinion, we don't needlet type = this.get('Content-Type');to get the type andif (!type) return ''to check if the type is unvalid.