Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme to add babel 7 instructions #1274

Merged
merged 1 commit into from Dec 7, 2018
Merged

Conversation

vikr01
Copy link
Contributor

@vikr01 vikr01 commented Nov 24, 2018

  • Update mentioned babel dependencies to their corresponding new names.
  • Update links to babel dependencies mentioned.
  • @babel/register should not be intended for production (since it's building and then caching files during runtime). @babel/cli should be used to build the files.
  • Since the files will be built after babel is run, it isn't needed at runtime and is therefore only needed as a devDependency (npm install --save => npm install --save-dev).

@codecov
Copy link

codecov bot commented Nov 24, 2018

Codecov Report

Merging #1274 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1274   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files           5       5           
  Lines         395     395           
======================================
  Hits          395     395

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 281a04e...9b4ecaf. Read the comment docs.

Copy link

@havenchyk havenchyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fl0w
Copy link
Contributor

fl0w commented Nov 25, 2018

LGTM

@dead-horse dead-horse merged commit fc93c05 into koajs:master Dec 7, 2018
@vikr01 vikr01 deleted the babel7 branch December 20, 2018 04:46
kiku-jw pushed a commit to kiku-jw/koa that referenced this pull request Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants