Skip to content
This repository has been archived by the owner on Jan 30, 2024. It is now read-only.

Enable ftdi feature in probe-rs #377

Closed
IridiumXOR opened this issue Jan 26, 2023 · 7 comments · Fixed by #381
Closed

Enable ftdi feature in probe-rs #377

IridiumXOR opened this issue Jan 26, 2023 · 7 comments · Fixed by #381
Labels
type: enhancement Enhancement or feature request

Comments

@IridiumXOR
Copy link

Please, can you enable the ftdi feature for probe-rs dependency in order to be able to use also FTDI debuggers?
Thanks

@Urhengulas
Copy link
Member

Hi @IridiumXOR,

Do you know if we would wantftdi or ftdi-vendored (https://github.com/probe-rs/probe-rs/blob/master/probe-rs/Cargo.toml#L26-L27)? I didn't find any documentation about the difference.

@Urhengulas Urhengulas added the type: enhancement Enhancement or feature request label Jan 27, 2023
@IridiumXOR
Copy link
Author

I think it's a problem of licence 1 and 2. If I have understood correctly, we would want ftdi (ftdi-vendored compile a static library in order to circumvent possible license problems (in the second link the authors seems to say that there are no license problems)

@Urhengulas
Copy link
Member

Urhengulas commented Feb 3, 2023

@IridiumXOR Can you try if it works as you expect? Install probe-run with:

$ cargo install --git https://github.com/knurling-rs/probe-run --branch ftdi --features ftdi

You need to have libtfdi1 installed, but I am sure you know more about that than I do.

@IridiumXOR
Copy link
Author

I'm looking into the code of branch ftdi, where is the part that enable the ftdi feature of probe-rs?

@Urhengulas
Copy link
Member

Please see the changes in #381. You can install it with the instructions above.

@Urhengulas
Copy link
Member

@IridiumXOR did you have the opportunity to test it?

@IridiumXOR
Copy link
Author

Sorry, yes it works! you can close it

@bors bors bot closed this as completed in 646ae98 Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Enhancement or feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants