Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby 3.0 support + GitHub Actions (MSP-Greg) #64

Merged
merged 2 commits into from Sep 14, 2021
Merged

Ruby 3.0 support + GitHub Actions (MSP-Greg) #64

merged 2 commits into from Sep 14, 2021

Conversation

johnnyshields
Copy link
Contributor

@johnnyshields johnnyshields commented Aug 29, 2021 •
edited

This includes:

  • commits from Add GitHub Actions, trim jobs from Travis #59
  • adds Ruby 3.0 support.
  • removes travis.yml entirely
  • drops support for Ruby <= 2.1 (users on older Ruby can use an earlier version of this gem)
  • cleanup gempsec and add Ruby >= 2.2 condition to gemspec
  • removes unneeded magic comments coding: utf-8

@johnnyshields johnnyshields changed the title GitHub Actions (MSP-Greg) + Ruby 3.0 support Ruby 3.0 support + GitHub Actions (MSP-Greg) Aug 29, 2021
knu
knu requested changes Sep 2, 2021
View reviewed changes
Copy link
Owner

@knu knu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I'd like style changes separated from functional changes because it's hard to review when the two types of changes mixed.

CHANGELOG.md Outdated Show resolved Hide resolved
lib/unf_ext/version.rb Outdated Show resolved Hide resolved
unf_ext.gemspec Outdated Show resolved Hide resolved
@johnnyshields
Copy link
Contributor Author

johnnyshields commented Sep 2, 2021 •
edited

@knu changes done as requested.

I think it's difficult to support Ruby < 2.2 on Github Actions, that's the reason for dropping it. (Travis CI is dead.)

Since the published versions of this gem support older Ruby, and Ruby 2.1 was EOL in March, 2017, it's probably not an issue.

knu
knu reviewed Sep 6, 2021
View reviewed changes
Copy link
Owner

@knu knu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think I can squash and split the commits into meaningful sets of hunks, but do you intend to do that yourself?

@johnnyshields johnnyshields force-pushed the github-actions branch 2 times, most recently from 6dd5c36 to 5e094e2 Compare September 6, 2021 08:34
@johnnyshields
Add Github Actions CI support.
127cf65 
- Include commits from PR knu#59 from MSP-Greg
- Add Ruby 3.0 support.
- Remove travis.yml entirely
- Drop support for Ruby <= 2.1 (users on older Ruby can use an earlier version of this gem)
- Cleanup gempsec and add Ruby >= 2.2 condition to gemspec
- Remove unneeded magic comments coding: utf-8
@johnnyshields
Copy link
Contributor Author

@knu I've squashed the commits and included @MSP-Greg 's original commit.

@Stromweld Stromweld mentioned this pull request Sep 13, 2021
Open
knu
knu approved these changes Sep 14, 2021
View reviewed changes
Copy link
Owner

@knu knu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm merging this and will prepare for a new release.

@knu knu merged commit 8b25ab1 into knu:master Sep 14, 2021
@johnnyshields johnnyshields deleted the github-actions branch September 14, 2021 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knu knu knu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johnnyshields @knu @MSP-Greg