Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a better name for the internal function for setting the accessibility title #3050

Closed
knsv opened this issue May 17, 2022 · 0 comments · Fixed by #3051
Closed

Use a better name for the internal function for setting the accessibility title #3050

knsv opened this issue May 17, 2022 · 0 comments · Fixed by #3051
Assignees
@knsv
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@knsv
Copy link
Collaborator

knsv commented May 17, 2022

Change the name from setTitle to setAccTitle which consistent with the setAccDescription function.
@knsv knsv added Type: Bug / Error Something isn't working or is incorrect Status: Triage Needs to be verified, categorized, etc labels May 17, 2022
@knsv knsv self-assigned this May 17, 2022
knsv added a commit that referenced this issue May 17, 2022
@knsv
#3050 Renaming setTitle to setAccTitle
a387852
@knsv knsv mentioned this issue May 17, 2022
Merged
knsv added a commit that referenced this issue May 17, 2022
@knsv
Merge pull request #3051 from mermaid-js/3050_setTitle_rename
0fd1156 
#3050 Renaming setTitle to setAccTitle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@knsv knsv

Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#3050 Renaming setTitle to setAccTitle mermaid-js/mermaid
1 participant
@knsv