Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitGraph: add support for branch ordering #3002

Conversation

husa
Copy link
Contributor

@husa husa commented May 4, 2022

馃搼 Summary

add "order: NUM" syntax to branch creation

Resolves #2937

馃搹 Design Decisions

branches are sorted by order when returned to renderer

馃搵 Tasks

Make sure you

  • 馃摉 have read the contribution guidelines
  • 馃捇 have added unit/e2e tests (if appropriate)
  • 馃敄 targeted develop branch

@husa husa changed the title add support for branch ordering GitGraph: add support for branch ordering May 4, 2022
Copy link
Collaborator

@ashishjain0512 ashishjain0512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this feature was on the list of TODOs, and we will be happy to accept it.
I will add a minor tweak to allow the setting of the default/main branch order in case someone needs it.

@ashishjain0512 ashishjain0512 merged commit 1602755 into mermaid-js:develop May 6, 2022
@husa husa deleted the feature/2937-gitgraph-branch-ordering branch May 9, 2022 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitGraph: Arbitrary vertical ordering of branches
2 participants