Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added default new line in the diagram text before parsing for special… #2983

Merged
merged 1 commit into from Apr 28, 2022

Conversation

ashishjain0512
Copy link
Collaborator

Fixes #2871

📑 Summary

Adds an additional NewLine in the diagram code in the parsing step to avoid broken diagram during parsing.

Resolves #2871

📏 Design Decisions

Added additional safety for special cases like editors which can call the parser directly with trimmed code.

📋 Tasks

Make sure you

  • [X]:book: have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • [C] 🔖 targeted develop branch

@ashishjain0512 ashishjain0512 merged commit e2c78f1 into develop Apr 28, 2022
@ashishjain0512 ashishjain0512 deleted the #2871_Fix-broken_GitGraph_without_ending_NL branch April 28, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax error occurred when render git diagram code ended with EOF
1 participant