Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference mkdocs-mermaid2-plugin for MkDocs #2702

Merged
merged 1 commit into from Feb 10, 2022
Merged

Reference mkdocs-mermaid2-plugin for MkDocs #2702

merged 1 commit into from Feb 10, 2022

Conversation

jfuentescpp
Copy link
Contributor

mkdocs-mermaid2-plugin is also based on https://github.com/pugong/mkdocs-mermaid-plugin but it adds a good documentation.

馃搼 Summary

Change the referenced plugin for MkDocs

Resolves # -
I didn't open a new issue for this.

馃搹 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.
I checked the linked plugin and mermaid2. The second includes detailed docs that made it easy to use.

馃搵 Tasks

Make sure you

  • 馃摉 have read the contribution guidelines
  • 馃捇 have added unit/e2e tests (if appropriate)
  • 馃敄 targeted develop branch

`mkdocs-mermaid2-plugin` is also based on https://github.com/pugong/mkdocs-mermaid-plugin but it adds a good documentation.
Copy link
Collaborator

@ashishjain0512 ashishjain0512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update

@ashishjain0512 ashishjain0512 merged commit 3877b88 into mermaid-js:develop Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants