Skip to content

Version numbers for v8.10.1 not correctly reflected in source code #2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DanielFlaum opened this issue May 15, 2021 · 0 comments · Fixed by #2076
Closed

Version numbers for v8.10.1 not correctly reflected in source code #2074

DanielFlaum opened this issue May 15, 2021 · 0 comments · Fixed by #2076
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@DanielFlaum
Copy link

Describe the bug
The commit tagged as version 8.10.1 (417428a) actually shows 8.9.3 in package.json.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 417428a
  2. See diff for package.json

Expected behavior
The diff should show 8.10.1 instead of 8.9.3

Screenshots
image
@DanielFlaum DanielFlaum added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels May 15, 2021
mahimas28 added a commit to mahimas28/mermaid that referenced this issue May 16, 2021
@mahimas28
Fix for issue mermaid-js#2074 , updated version to 8.10.1
85faec7
@mahimas28 mahimas28 mentioned this issue May 16, 2021
Merged
3 tasks
knsv added a commit that referenced this issue May 17, 2021
@knsv
Merge pull request #2076 from mahimas28/develop

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
1f86ec3 
Fix for issue #2074 , updated version to 8.10.1
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for issue #2074 , updated version to 8.10.1 mahimas28/mermaid
1 participant
@DanielFlaum