Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle HTML errors in all RestTemple requests in CVR (easy win) #743

Closed
mandawilson opened this issue Nov 8, 2021 · 1 comment
Closed
Labels
backend-scrum items centered around engineering activities

Comments

@mandawilson
Copy link
Collaborator

Done Condition (What do we need? Why do we need it? Keep this is small as possible!)

In all RestTemplate requests we should handle getting an exception that includes an HTML response, e.g. https://github.com/knowledgesystems/cmo-pipelines/pull/907/files. We might also want to output the status code.

Note (from: spring-projects/spring-framework#24964):

IOException or HttpMessageNotReadableException are problems while reading the response body which can only be read once. This is why the code here raises a plain RestClientException. By contrast for 4xx and 5xx we raise RestClientResponseException (or one of its sub-classes) with the body.

Technical Description (How are we going to achieve the above)

Potential Issues

Dependencies

Technical Requirements

Outside People/Teams

Changes

@mandawilson mandawilson added the backend-scrum items centered around engineering activities label Nov 8, 2021
@averyniceday averyniceday changed the title Handle HTML errors in all RestTemple requests in CVR Handle HTML errors in all RestTemple requests in CVR (easy win) Dec 7, 2021
@sheridancbio
Copy link
Collaborator

@averyniceday I have approved the PR .. feel free to merge and deploy (or I can do it if you prefer)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend-scrum items centered around engineering activities
Projects
None yet
Development

No branches or pull requests

3 participants