From eb2c60b3d57502ff0814423c9b348a64f73ddc48 Mon Sep 17 00:00:00 2001 From: knknk98 <65712721+knknk98@users.noreply.github.com> Date: Thu, 13 Jan 2022 21:57:48 +0900 Subject: [PATCH] fix(VDialog): change the role from "document" to "dialog" fixes #14231 --- packages/vuetify/src/components/VDialog/VDialog.ts | 2 +- .../VDialog/__tests__/__snapshots__/VDialog.spec.ts.snap | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/vuetify/src/components/VDialog/VDialog.ts b/packages/vuetify/src/components/VDialog/VDialog.ts index 5ffa773b853..e112d180e52 100644 --- a/packages/vuetify/src/components/VDialog/VDialog.ts +++ b/packages/vuetify/src/components/VDialog/VDialog.ts @@ -253,7 +253,7 @@ export default baseMixins.extend({ this.$createElement('div', { class: this.contentClasses, attrs: { - role: 'document', + role: 'dialog', tabindex: this.isActive ? 0 : undefined, ...this.getScopeIdAttrs(), }, diff --git a/packages/vuetify/src/components/VDialog/__tests__/__snapshots__/VDialog.spec.ts.snap b/packages/vuetify/src/components/VDialog/__tests__/__snapshots__/VDialog.spec.ts.snap index 88211542135..2b32aee7135 100644 --- a/packages/vuetify/src/components/VDialog/__tests__/__snapshots__/VDialog.spec.ts.snap +++ b/packages/vuetify/src/components/VDialog/__tests__/__snapshots__/VDialog.spec.ts.snap @@ -1,7 +1,7 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP exports[`VDialog.ts should only set tabindex if active 1`] = ` -
@@ -13,7 +13,7 @@ exports[`VDialog.ts should only set tabindex if active 1`] = ` `; exports[`VDialog.ts should only set tabindex if active 2`] = ` -