From 742aaff85a468b185d8d161cdbfa4d3a1e3d395c Mon Sep 17 00:00:00 2001 From: mingoing Date: Fri, 2 Sep 2022 11:53:08 +0800 Subject: [PATCH 1/2] fix: insert array into json column --- lib/client.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/client.js b/lib/client.js index 1525fa0b5e..b0f3605cb0 100644 --- a/lib/client.js +++ b/lib/client.js @@ -30,7 +30,7 @@ const Logger = require('./logger'); const { POOL_CONFIG_OPTIONS } = require('./constants'); const ViewBuilder = require('./schema/viewbuilder.js'); const ViewCompiler = require('./schema/viewcompiler.js'); -const isPlainObject = require('lodash/isPlainObject'); +const isObjectLike = require('lodash/isObjectLike'); const debug = require('debug')('knex:client'); @@ -396,7 +396,7 @@ class Client extends EventEmitter { if (i > 0) str += ', '; let value = values[i]; // json columns can have object in values. - if (isPlainObject(value)) { + if (isObjectLike(value)) { value = JSON.stringify(value); } str += this.parameter( From 77b836109a93b2bbb090713a73dd0b04580f854f Mon Sep 17 00:00:00 2001 From: mingoing Date: Fri, 2 Sep 2022 13:14:47 +0800 Subject: [PATCH 2/2] fix: determine array --- lib/client.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/client.js b/lib/client.js index b0f3605cb0..e3128616cb 100644 --- a/lib/client.js +++ b/lib/client.js @@ -30,7 +30,7 @@ const Logger = require('./logger'); const { POOL_CONFIG_OPTIONS } = require('./constants'); const ViewBuilder = require('./schema/viewbuilder.js'); const ViewCompiler = require('./schema/viewcompiler.js'); -const isObjectLike = require('lodash/isObjectLike'); +const isPlainObject = require('lodash/isPlainObject'); const debug = require('debug')('knex:client'); @@ -396,7 +396,7 @@ class Client extends EventEmitter { if (i > 0) str += ', '; let value = values[i]; // json columns can have object in values. - if (isObjectLike(value)) { + if (isPlainObject(value) || Array.isArray(value)) { value = JSON.stringify(value); } str += this.parameter(