From 0740991c0ef0c487e11d68927dd8ae64e096068e Mon Sep 17 00:00:00 2001 From: Ethan Hur Date: Thu, 13 Dec 2018 20:17:16 +0900 Subject: [PATCH 1/2] add test that clearing offset --- test/unit/query/builder.js | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/test/unit/query/builder.js b/test/unit/query/builder.js index 218670a87d..30caa24d9e 100644 --- a/test/unit/query/builder.js +++ b/test/unit/query/builder.js @@ -6476,6 +6476,33 @@ describe('QueryBuilder', function() { ); }); + it('should clear offset when passing null', function() { + testsql( + qb() + .from('test') + .offset(10) + .offset(null), + { + mysql: { + sql: 'select * from `test`', + bindings: [], + }, + mssql: { + sql: 'select * from [test]', + bindings: [], + }, + pg: { + sql: 'select * from "test"', + bindings: [], + }, + 'pg-redshift': { + sql: 'select * from "test"', + bindings: [], + }, + }, + ); + }); + it('allows passing builder into where clause, #162', function() { var chain = qb() .from('chapter') From cbc1b84cd407b668ec56978d59a46494658ea293 Mon Sep 17 00:00:00 2001 From: Ethan Hur Date: Thu, 13 Dec 2018 20:25:35 +0900 Subject: [PATCH 2/2] fix typo --- test/unit/query/builder.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/unit/query/builder.js b/test/unit/query/builder.js index 30caa24d9e..d6ac6826b3 100644 --- a/test/unit/query/builder.js +++ b/test/unit/query/builder.js @@ -6499,7 +6499,7 @@ describe('QueryBuilder', function() { sql: 'select * from "test"', bindings: [], }, - }, + } ); });