Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document not to use propagateCreateError: false #6043

Open
rjmackay opened this issue Mar 25, 2024 · 0 comments
Open

Document not to use propagateCreateError: false #6043

rjmackay opened this issue Mar 25, 2024 · 0 comments

Comments

@rjmackay
Copy link

Environment

ALL

Missing / erroneus documentation

There are multiple comments on github issues directing users never to use propagateCreateError: false in the tarn pool config (like:
#3447 (comment)) but there is not mention of it in the docs.

Could this be included in documentation here? https://knexjs.org/guide/#pool

Ideally, with information on why this shouldn't be enabled.

I would be happy to PR docs, but I don't fully understand the reason why this shouldn't be added myself. From a naive look at the tarn docs it seems like you would want to enable this so failed attempts to connect get retried.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant