Query doesn't work with .stream() if options not exists

[gabolera]

Environment

Knex version: 3.1.0
Database + version: Oracle 18c
OS: Windows (WSL Ubuntu 22.04)

Bug

1. On make a query using stream method the knex force me passing a parameter in options!

Example: (with first case, never join .on('data'))

// This dosen't work
const stream = db.raw(`select * from users`).stream()

stream.on('data', (chunk) => {
  console.log(chunk)
})



// But... This work
const stream = db.raw(`select * from users`).stream({})

stream.on('data', (chunk) => {
  console.log(chunk)
})

If is optional parameters is should not a impeditive for use .pipe() .on()

[rluvaton]

Can you create a pr to fix this?

[gabolera]

Shure 🙂

[gabolera]

Finished tests, and okay for oracledb driver (PR #6040) but a question arose here.

In this case i solved only for oracledb driver! I see example used on mysql

knex/lib/dialects/mysql/index.js

Lines 104 to 107 in aedba5e

	_stream(connection, obj, stream, options) {
	if (!obj.sql) throw new Error('The query is empty');
	options = options || {};

But maybe it's interesting fix this on here where stream options is {} with default for all drivers?

knex/lib/client.js

Lines 157 to 160 in aedba5e

	stream(connection, queryParam, stream, options) {
	const queryObject = enrichQueryObject(connection, queryParam, this);
	return this._stream(connection, queryObject, stream, options);
	}

stream(connection, queryParam, stream, options = {}) {

or this is a bad idea?

Thanks :) @rluvaton