Fixes _setNullableState not respecting schema #6025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6024
Fix seems obvious to me.
I checked whether I can add tests for using a non-standard schema.
Unfortunately
createSchemaanddropSchemaare only available for Postgres. (=> Could make a test for pg)Also the tests in set-nullable.spec.js are not really set up to deal with schemas.
Regarding the fix:
If
this.schemaNameRawis undefined, the PR's changes will not affect the query, so everything that used to work still works.For tables in other schemas the code never worked, now it could (and when I use my fork in our project, it does...) => seems better to me.