Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compileSqlOnError documentation and typings #5452

Closed
Cellule opened this issue Jan 17, 2023 · 1 comment
Closed

compileSqlOnError documentation and typings #5452

Cellule opened this issue Jan 17, 2023 · 1 comment

Comments

@Cellule
Copy link
Contributor

Cellule commented Jan 17, 2023

Environment

Knex version: 2.4.0

If issue is about TypeScript definitions, tag @lorefnon.

Missing / erroneus documentation

Send issue to documentation repo, or fix it and send PR https://github.com/knex/documentation

compileSqlOnError is a configuration added in version 2.4
See #5282
It seems to be missing in the typings for the configuration object

There was a documentation PR knex/documentation#436
However, that documentation doesn't appear on the documentation website (Not published since?)
https://knexjs.org/guide/#compileonsqlerror

@Cellule
Copy link
Contributor Author

Cellule commented Jan 17, 2023

Nevermind for the typings, I had an issue with yarn and it didn't actually update to 2.4 😓
I'll open an issue on the documentation PR to get the new config published on the website

@Cellule Cellule closed this as completed Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant