Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: orWhereJson Functions #5361

Merged
merged 1 commit into from Nov 18, 2022
Merged

Fix: orWhereJson Functions #5361

merged 1 commit into from Nov 18, 2022

Conversation

SuhyeongCho
Copy link
Contributor

Fixed orWhereJson... functions like orWhereJsonSupersetOf, orWhereJsonNotSupersetOf, orWhereJsonSubsetOf and orWhereJsonNotSubsetOf,

The problem

I found a issues about orWhereJsonSupersetOf and orWhereJsonSubsetOf which behaved the same as whereJsonSupersetOf and whereJsonSubsetOf

@SuhyeongCho SuhyeongCho marked this pull request as draft October 18, 2022 05:53
@SuhyeongCho SuhyeongCho marked this pull request as ready for review October 18, 2022 05:53
@SuhyeongCho SuhyeongCho changed the title Fix: orWhereJson Fix: orWhereJson Functions Oct 18, 2022
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 92.369% when pulling 86a2dd6 on SuhyeongCho:master into d39051f on knex:master.

@OlivierCavadenti OlivierCavadenti merged commit 72bd1f7 into knex:master Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierCavadenti OlivierCavadenti OlivierCavadenti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SuhyeongCho @coveralls @OlivierCavadenti