Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing type for 'expirationChecker' on PgConnectionConfig #5334

Merged
merged 3 commits into from Sep 27, 2022

Conversation

sam-super
Copy link
Contributor

expirationChecker currently works with PgConnectionConfig if you ignore the type error.

@@ -3024,6 +3024,7 @@ export declare namespace Knex {
connectionTimeoutMillis?: number;
types?: PgCustomTypesConfig;
options?: string;
expirationChecker?(): boolean;
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add tsd test for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try. If i'm honest, i didn't do it because I didn't see those tests for the types that already define expirationChecker, so this maintains the current standard. I do appreciate it's hard to improve things if we only maintain the current standards tho.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kibertoad i've not done TSD tests before - is this right? 2e7fca0

@coveralls
Copy link

coveralls commented Sep 23, 2022

Coverage Status

Coverage remained the same at 92.334% when pulling 36839f1 on sam-super:pg-conf-type-expiration-checker into f7ccde8 on knex:master.

@sam-super sam-super force-pushed the pg-conf-type-expiration-checker branch 2 times, most recently from 323c034 to 000ea5d Compare September 27, 2022 16:19
Co-authored-by: Igor Savin <iselwin@gmail.com>
@kibertoad kibertoad merged commit d39051f into knex:master Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants