New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing type for 'expirationChecker' on PgConnectionConfig #5334
fix: add missing type for 'expirationChecker' on PgConnectionConfig #5334
Conversation
@@ -3024,6 +3024,7 @@ export declare namespace Knex { | |||
connectionTimeoutMillis?: number; | |||
types?: PgCustomTypesConfig; | |||
options?: string; | |||
expirationChecker?(): boolean; | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add tsd test for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll try. If i'm honest, i didn't do it because I didn't see those tests for the types that already define expirationChecker
, so this maintains the current standard. I do appreciate it's hard to improve things if we only maintain the current standards tho.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kibertoad i've not done TSD tests before - is this right? 2e7fca0
323c034
to
000ea5d
Compare
Co-authored-by: Igor Savin <iselwin@gmail.com>
expirationChecker currently works with PgConnectionConfig if you ignore the type error.