Fix lib/.gitignore path separator on Windows. #5325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on Windows, the script responsible for generating
lib/.gitignorewhen executed by git hooks uses the wrong path separator for .gitignore files, preventing TypeScript-generated JS files from being consistently ignored on Windows machines.On Windows only, the generated path uses the Windows-style backslash path separator due to node's path package conventions. .gitignore syntax always requires use of the POSIX-style forward slash. (Reference). This simply normalizes all path separators to forward slashes in the outputted .gitignore file.
Just a very minor issue I encountered when working with the codebase that I had to fix.