Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix changing the default value of a boolean column in SQLite #5319

Merged
merged 1 commit into from Sep 1, 2022

Conversation

nickrum
Copy link
Contributor

@nickrum nickrum commented Sep 1, 2022

The formatDefault() function expects the type parameter to be a Knex internal type instead of a SQL type.

@coveralls
Copy link

coveralls commented Sep 1, 2022

Coverage Status

Coverage increased (+0.003%) to 92.287% when pulling b31b477 on nickrum:fix-sqlite-alter-boolean-default into f52b2c5 on knex:master.

The `formatDefault()` function expects the type parameter to be a Knex internal type instead of a SQL type.
@nickrum nickrum force-pushed the fix-sqlite-alter-boolean-default branch from fe18a17 to b31b477 Compare September 1, 2022 14:21
@kibertoad kibertoad merged commit 6bed5e9 into knex:master Sep 1, 2022
@nickrum nickrum deleted the fix-sqlite-alter-boolean-default branch September 1, 2022 15:09
@azrikahar
Copy link

Hi! Just wondering is this PR meant to be included 2.3.0? Noticed the commit hash to include this, but seems like it's not included, if I'm not mistaken. Totally understand if it's intentionally deferred 👍

@kibertoad
Copy link
Collaborator

no, it was merged after 2.3.0 was released

@azrikahar
Copy link

Thanks! Pardon the confusion on my end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants