New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: inline primary key creation for postgres flavours #5233
Merged
kibertoad
merged 3 commits into
knex:master
from
hairmare:fix/postgresql-primary-in-table-not-in-field
Jun 30, 2022
Merged
feat: inline primary key creation for postgres flavours #5233
kibertoad
merged 3 commits into
knex:master
from
hairmare:fix/postgresql-primary-in-table-not-in-field
Jun 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@intech Could you please take a look? |
@kibertoad ok, tomorrow |
This comment was marked as off-topic.
This comment was marked as off-topic.
@intech ping :) |
I'm here. Sorry for the long wait |
@kibertoad LGTM |
kibertoad
approved these changes
Jun 30, 2022
Any idea when there will be a new release which includes this fix? |
I'll do my best to do it this week |
Any word on this? |
@OlivierCavadenti Can you try publishing? I'm out of town till sunday, no laptop :( |
Released in 2.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of my work in #5212. It's aimed at really fixing #5211
rowid
column when using.primary()
#5211#5212 implemented
uuid(<id>, { primaryKey: true })
for allowing to usePRIMARY KEY
on the field type in the column declaration. This aims at adding support for a distinctPRIMARY KEY
constraint during table creating.Both of these solutions want to make life easier for folx using CockroachDB which autogenerates a
rowid
primary if none is specified during initial table creating.I'm creating this as a draft PR, I'll finalize it once the accompanying docs pr is also done and CI is green.
Please let me know if this is a feasible way to go forward and if there is some special consideration needed for any non-postgresql postgres flavours (i don't know them well).
tasks