New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for search path to be set before returning connection #5107

Merged

OlivierCavadenti merged 1 commit into knex:master from s0meone:master

Apr 7, 2022

Contributor

s0meone commented Apr 7, 2022

In my test suite the connection was sometimes returned too fast and before the search path was actually set.

Since setSchemaSearchPath is running the query in a Promise we should wait for this promise to finish before continuing.


          Wait for search path to be set before continuing

89c1c27

OlivierCavadenti approved these changes

View reviewed changes

OlivierCavadenti merged commit 3435b46 into knex:master

Collaborator

kibertoad commented Apr 12, 2022

Released in 1.0.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment