Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrapped Unions Fixes #5072

Merged
merged 3 commits into from Mar 19, 2022
Merged

Wrapped Unions Fixes #5072

merged 3 commits into from Mar 19, 2022

Conversation

OlivierCavadenti
Copy link
Collaborator

@OlivierCavadenti OlivierCavadenti commented Mar 18, 2022 •
edited

@kibertoad
Copy link
Collaborator

@OlivierCavadenti Are you planning any additional fixes in the nearby future, or can I cut new version after this is merged?

@OlivierCavadenti
Copy link
Collaborator Author

@OlivierCavadenti Are you planning any additional fixes in the nearby future, or can I cut new version after this is merged?

No, in the pipe, (in this order) : finish async / await all query integration files, finish all my opened PR (cast + override connection), then I will dig in open PR to see what we can finish.

@OlivierCavadenti OlivierCavadenti merged commit c3e41e3 into knex:master Mar 19, 2022
@OlivierCavadenti OlivierCavadenti deleted the union-fix branch March 19, 2022 12:05
@OlivierCavadenti OlivierCavadenti mentioned this pull request Mar 29, 2022
Closed
@felixmosh
Copy link
Contributor

When this fix will be published?

@kibertoad
Copy link
Collaborator

I'll try to publish new version today.

@kibertoad
Copy link
Collaborator

Released in 1.0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kibertoad kibertoad kibertoad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Syntax errors when using union with first/limit in 1.0.4
3 participants
@OlivierCavadenti @kibertoad @felixmosh