New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support string json in json values #4988

Merged

kibertoad merged 1 commit into knex:master from OlivierCavadenti:accept-string-json-4979

Jan 31, 2022

Collaborator

OlivierCavadenti commented Jan 31, 2022

Json values for Json functions now support Json in string format (not only json object).
await knex('table_name').whereJsonSupersetOf('path', "hello") is always not supported (regarding @> Postgres documentation, this notation doesn't make sense, whereJsonSupersetOf checks two valid json objects).
Closes whereJsonSupersetOf does not take String as second argument #4979


          Support string json in json values

11e4f46

OlivierCavadenti requested a review from kibertoad

January 31, 2022 19:45

kibertoad approved these changes

View reviewed changes

kibertoad merged commit 2986f8c into knex:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment