New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor more tests to use cli-testlab #3640

Merged

kibertoad merged 2 commits into master from chore/refactor-cli-test

Jan 28, 2020

Collaborator

kibertoad commented Jan 28, 2020

No description provided.


          Refactor more tests to use cli-testlab

0b73431

kibertoad commented

View reviewed changes

lib/util/parse-connection.js

               module.exports = function parseConnectionString(str) {
                 const parsed = url.parse(str, true);
                 let { protocol } = parsed;
-                if (protocol === null) {
+                const isDriveLetter = isWindows && protocol.length === 2;

Collaborator Author

kibertoad Jan 28, 2020

Original implementation didn't support sqlite paths to begin with drive letter, e. g. "c:/knex/migrations"


          Execute affected tests

5857b81

kibertoad merged commit c14252d into master

kibertoad deleted the chore/refactor-cli-test branch

January 28, 2020 01:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment