Fix collation when renaming column in MySQL dialect #2666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elhigu
requested changes
Jul 2, 2018
# Conflicts: # src/dialects/mysql/schema/tablecompiler.js # test/integration/builder/additional.js
kibertoad
approved these changes
Feb 1, 2022
|
Released in 1.0.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ran into an issue today where
.renameColumn()was failing because the columns had a different collation after the rename and recreating the foreign keys caused an error. The collation was being lost during thealter change. This change preserves the collation through the alter.I'm not familiar enough with the knex test suite to know how to go about adding an integration test for this. If someone can provide some pointers, I'd appreciate it. Didn't want to let that stop me raising the issue and providing this patch.
Thanks!