Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #94 #95

Closed
wants to merge 1 commit into from
Closed

Closes #94 #95

wants to merge 1 commit into from

Conversation

ozziest
Copy link

@ozziest ozziest commented Jan 23, 2022

Closes #94

@ozziest ozziest marked this pull request as ready for review January 23, 2022 11:29
@kibertoad
Copy link
Contributor

Thank you! Can you also add test?

@ozziest
Copy link
Author

ozziest commented Jan 23, 2022

I am not sure how to add tests properly.

First, I realized that the knex version is ^0.95.14 in the package.json file. Should I update it to the latest version? Also, in the latest version, vscode-sqlite3 package is being looked for. Should I add that package?

@kibertoad
Copy link
Contributor

Yes, would be good to add both.

@kibertoad
Copy link
Contributor

@ozziest Do you need any help?

@ozziest
Copy link
Author

ozziest commented Feb 2, 2022

@kibertoad , I am sorry but I couldn't find time to work on it. :/ If I am blocking the issue, someone else can work on it because I will not be free this week. If you can give me another week, I would love to contribute it as I can.

@ozziest
Copy link
Author

ozziest commented Feb 13, 2022

Hi @kibertoad ,

I am sorry but I couldn't resolve the issue. Even I updated knex version, and add vscode-sqlite3 to the package.json, when I run tests, I get the following errors;

$ npm install sqlite3 --save
Cannot find module '@vscode/sqlite3'
Require stack:
- /home/ozzy/Desktop/github/ozziest/knex-schema-inspector/node_modules/knex/lib/dialects/sqlite3/index.js
- /home/ozzy/Desktop/github/ozziest/knex-schema-inspector/node_modules/knex/lib/knex-builder/internal/config-resolver.js
- /home/ozzy/Desktop/github/ozziest/knex-schema-inspector/node_modules/knex/lib/knex-builder/Knex.js
- /home/ozzy/Desktop/github/ozziest/knex-schema-inspector/node_modules/knex/lib/index.js
- /home/ozzy/Desktop/github/ozziest/knex-schema-inspector/node_modules/knex/knex.js
- /home/ozzy/Desktop/github/ozziest/knex-schema-inspector/test/mysql.spec.ts
- /home/ozzy/Desktop/github/ozziest/knex-schema-inspector/node_modules/mocha/lib/esm-utils.js
- /home/ozzy/Desktop/github/ozziest/knex-schema-inspector/node_modules/mocha/lib/mocha.js
- /home/ozzy/Desktop/github/ozziest/knex-schema-inspector/node_modules/mocha/lib/cli/one-and-dones.js
- /home/ozzy/Desktop/github/ozziest/knex-schema-inspector/node_modules/mocha/lib/cli/options.js
- /home/ozzy/Desktop/github/ozziest/knex-schema-inspector/node_modules/mocha/bin/mocha

Probably I am missing some little point but I think that it can be solved quickly by someone who know the package very well.

@rijkvanzanten
Copy link
Collaborator

@ozziest I think it's simply because @vscode/sqlite isn't installed in this project (yet). A npm install @vscode/sqlite -D should do the trick 🙂

@ozziest
Copy link
Author

ozziest commented Mar 3, 2022

@ozziest I think it's simply because @vscode/sqlite isn't installed in this project (yet). A npm install @vscode/sqlite -D should do the trick slightly_smiling_face

Unfortunately, I get the same error after I install vscode/sqlite. I have no idea why. I really wanted to make some contribution but I don't have enough information about what's going on here. That's why I have to close my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

better-sqlite driver is not supported
3 participants