Test that trigger is not ready before dependency exists with dependency annotation #7896
Labels
area/test-and-release
Test infrastructure, tests or release
good first issue
Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
help wanted
Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
kind/feature-request
triage/accepted
Issues which should be fixed (post-triage)
Problem
Currently in the rekt test
TestTriggerDependencyAnnotation
, we do not verify that the trigger is not ready until the PingSource exists. A simple way to fix this would be to move thetrigger.IsReady(...)
call from theSetup
phase to theRequirement
phase, and then add a new step function to theSetup
phase which checks that the trigger is not ready with reasonDependencyDoesNotExist
.Persona:
Which persona is this feature for?
Exit Criteria
The rekt test verifies that the trigger is not ready with reason
DependencyDoesNotExist
before the PingSource is installed.Time Estimate (optional):
How many developer-days do you think this may take to resolve? 1
Additional context (optional)
eventing/test/rekt/features/trigger/feature.go
Line 44 in c104df5
The text was updated successfully, but these errors were encountered: