Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Upstream] If readiness is signalled via. status does it properly implement observeredGeneration #364

Closed
carlisia opened this issue Aug 10, 2022 · 7 comments
Closed

[Upstream] If readiness is signalled via. status does it properly implement observeredGeneration #364

carlisia opened this issue Aug 10, 2022 · 7 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone
Icebox

Comments

@carlisia
Copy link
Member

carlisia commented Aug 10, 2022 •
edited

Should this be in gateway api's conformance testing?

Ref.: knative-extensions/net-istio#585.
@carlisia
Copy link
Member Author

Closing since this is a dup of an existing issue: knative-extensions/net-istio#585.

@carlisia
Copy link
Member Author

Didn't notice that issue is in the net-istio repo. Reopening.

@carlisia carlisia reopened this Aug 10, 2022
@carlisia carlisia added this to the Icebox milestone Aug 10, 2022
@carlisia carlisia changed the title If readiness is signalled via. status does it properly implement observeredGeneration - https://github.com/knative-sandbox/net-istio/issues/585 [Upstream] If readiness is signalled via. status does it properly implement observeredGeneration - https://github.com/knative-sandbox/net-istio/issues/585 Aug 10, 2022
@carlisia carlisia changed the title [Upstream] If readiness is signalled via. status does it properly implement observeredGeneration - https://github.com/knative-sandbox/net-istio/issues/585 [Upstream] If readiness is signalled via. status does it properly implement observeredGeneration Aug 10, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2022

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 9, 2022
@knative-prow-robot
Copy link
Contributor

This issue or pull request is stale because it has been open for 90 days with no activity.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close

/lifecycle stale

@dprotaso
Copy link
Contributor

dprotaso commented Dec 9, 2022 •
edited

I'm updating the upstream conformance test to assert this - kubernetes-sigs/gateway-api#1586

@dprotaso
Copy link
Contributor

dprotaso commented Dec 9, 2022

/lifecycle frozen

@knative-prow knative-prow bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 9, 2022
@dprotaso
Copy link
Contributor

dprotaso commented Feb 7, 2023

Upstream conformance changes landed that assert HTTPRoute conditions have observedGeneration

The work to read that info is part of #425

@dprotaso dprotaso closed this as completed Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
No open projects
Gateway API Roadmap
Status: Done
Milestone
Icebox
Development

No branches or pull requests
3 participants
@carlisia @dprotaso @knative-prow-robot