Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make dotenv.Parser behave like env.Provider #179

Merged
merged 2 commits into from Nov 1, 2022
Merged

Conversation

jxsl13
Copy link
Contributor

@jxsl13 jxsl13 commented Nov 1, 2022

No description provided.

@jxsl13
Copy link
Contributor Author

jxsl13 commented Nov 1, 2022

the provided tests pass.

@knadh
Copy link
Owner

knadh commented Nov 1, 2022

Could you please explain what reverseCB does?

@jxsl13
Copy link
Contributor Author

jxsl13 commented Nov 1, 2022

it keeps track of the environment key manipulation that is happening within cb
and allows to map the key back to its source.

This is interesting when you want to Marshal the configuration back to its file representation.

@knadh knadh merged commit d38d286 into knadh:master Nov 1, 2022
@ste93cry
Copy link

ste93cry commented Jan 3, 2023

@knadh is there any ETA for this to be released?

@knadh
Copy link
Owner

knadh commented Jan 4, 2023

Ah, didn't realise this wasn't released. Just pushed v1.4.5.

@ste93cry
Copy link

ste93cry commented Jan 4, 2023

Thanks. Btw, I see the tag, but not the release. Did you forget to create it?

@knadh
Copy link
Owner

knadh commented Jan 5, 2023

Added a GitHub release. That isn't necessary for go get though, which works based on git tags.

@jxsl13 jxsl13 deleted the dotenv branch January 17, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants