Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints and run mypy #23

Merged
merged 1 commit into from May 31, 2021
Merged

Add type hints and run mypy #23

merged 1 commit into from May 31, 2021

Conversation

mmaslowskicc
Copy link
Contributor

Fixes #20.

@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #23 (42690ac) into master (c3f0b67) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage   96.65%   96.73%   +0.08%     
==========================================
  Files           8        8              
  Lines         269      276       +7     
==========================================
+ Hits          260      267       +7     
  Misses          9        9              
Flag Coverage Δ
linux 89.85% <98.55%> (+0.26%) ⬆️
macos 96.01% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
port_for/__init__.py 100.00% <100.00%> (ø)
port_for/api.py 96.25% <100.00%> (+0.09%) ⬆️
port_for/ephemeral.py 91.42% <100.00%> (+0.25%) ⬆️
port_for/store.py 94.23% <100.00%> (-0.11%) ⬇️
port_for/utils.py 100.00% <100.00%> (ø)
tests/test_cases.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3f0b67...42690ac. Read the comment docs.

warn_unreachable = True
warn_unused_ignores = True

# Bundled third-party package.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like something before 0.4.1. If we use current docopt and the types-docopt package, we would get its annotation. I don't know any reason for bundling it now.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well.. me neither. Maybe it was to limit the needed dependencies to bare none by then 🤔
I suppose I could use click for that, but we can migrate to the dependency I suppose. The codebase wasn't refreshed since 2012 (except for black) and future python versions might require unintended changes that will have to be tested (and it's not something I'd like to do)

@fizyk fizyk merged commit 3f75995 into kmike:master May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add type hints / pep 561
2 participants