Skip to content
This repository has been archived by the owner on Dec 5, 2022. It is now read-only.

MVP refactorings & cleanups #20

Open
9 tasks
klummy opened this issue Feb 12, 2019 · 0 comments
Open
9 tasks

MVP refactorings & cleanups #20

klummy opened this issue Feb 12, 2019 · 0 comments
Labels
maintenance CI tasks and other maintenance activities
Projects

Comments

@klummy
Copy link
Owner

klummy commented Feb 12, 2019

These are tasks that don't affect functionality but are improve the user and development experience. Also, meant as a way to track pending

  • Complete migration from class components to hook based components where possible
  • The QueryPane component is becoming too complicated and will likely become harder to maintain. Clean it up by splitting where necessary and rethink logic.
  • Modify the remove NotificationItem effect to trigger when the notification is in view, not when it appears (perhaps using IntersectionObserver?)
  • Allow for scrolling the notification list when the items overflow the screen.
  • Don't dismiss/remove the notification when it's hovered on for a better usability experience
  • Consider looking for a better alternative to replacing items in arrays (used for update* tasks in reducers)

Pending test tasks:

  • Test Redux action creators and reducers
  • Test all components especially those that have conditional rendering within them
  • Test effects and services
@klummy klummy created this issue from a note in Grapple 1.0 (To do) Feb 12, 2019
@klummy klummy added the maintenance CI tasks and other maintenance activities label Feb 18, 2019
@klummy klummy changed the title Refactor: QueryPane cleanup MVP refactorings & cleanups Feb 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintenance CI tasks and other maintenance activities
Projects
Grapple 1.0
  
Backlog
Development

No branches or pull requests

1 participant