Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Staking] A conflict of stakingupdateinterval and proposerupdateinterval #1853

Open
hyunsooda opened this issue May 26, 2023 · 1 comment
Open
Labels
issue/bug Issues with the code-level bugs.

Comments

@hyunsooda
Copy link
Contributor

Is your request related to a problem? Please describe.

Background:
Both reward.stakingupdateinterval and reward.proposerupdateinterval serve as factors determining when the staking values should be refreshed within a given interval. It is important to note that these factors are prohibited from being updated and listed in the forbidden map.

Problem:
Any attempt to reset these values, whether through modifications in the genesis.json file or via a hardfork update, can result in undesired and semantically incorrect behavior. To illustrate this point, let's consider a chain with the configuration reward.stakingupdateinterval=10 and reward.proposerupdateinterval=300. In this scenario, the staking values are retrieved based on the proposer update interval value (i.e., 300), rather than 10. Consequently, this setting is equivalent to having reward.stakingupdateinterval=300.
The correct functioning of Cypress is attributed to the settings where reward.proposerupdateinterval=3600 and reward.stakingupdateinterval=86400. Here, 3600 acts as a divisor of 86400, making the setting equivalent to reward.stakingupdateinterval=86400 with reward.proposerupdateinterval=none (rendering the reward.proposerupdateinterval value meaningless).

Describe the solution you'd like
Conclusion:
The tidy-up is to remove the reward.proposerupdateinterval key from the governance list. Although the patch itself is not particularly complex, its patch involves a large context in terms of chain's configuration. It is important to take note of this issue for future tidy-ups.

Describe alternatives you've considered

Additional context

@exalate-issue-sync
Copy link

Exalate commented: Issue Created by: hyunsooda

@sjnam sjnam added issue/bug Issues with the code-level bugs. and removed Github labels Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue/bug Issues with the code-level bugs.
Projects
None yet
Development

No branches or pull requests

2 participants