Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Consensus] Useless lock #1695

Open
hyunsooda opened this issue Nov 15, 2022 · 1 comment
Open

[Consensus] Useless lock #1695

hyunsooda opened this issue Nov 15, 2022 · 1 comment
Assignees
@jiseongnoh
Labels
enhancement New feature or enhancement Github
Projects
Consensus

Comments

@hyunsooda
Copy link
Contributor

Tthe List() function in both weighted.go and default.go returns the current set of validators with the exclusive access guard. However, it seems not a safe implementation because other functions may touch the returned validators at the time of use. It results in memory inconsistency. The recommendation to fix this is to replace List() with a safe guard that guarantees exclusive access to the validator array.
@hyunsooda hyunsooda mentioned this issue Nov 15, 2022
Closed
@mckim19 mckim19 added this to To do in Consensus via automation Nov 15, 2022
@mckim19 mckim19 assigned jiseongnoh and unassigned mckim19 Jan 16, 2023
@exalate-issue-sync
Copy link

Exalate commented: Issue Created by: hyunsooda

@sjnam sjnam added enhancement New feature or enhancement and removed Github labels Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jiseongnoh jiseongnoh

Labels
enhancement New feature or enhancement Github
Projects
Consensus
To do
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sjnam @hyunsooda @jiseongnoh @mckim19