The status of state migration changed before the removal of old database

[aidan-kwon]

Problem
There is a problem if a node stops Klaytn process just after finishing state migration.
Because there are some steps after changing the status of state migration to finished, and removing old database especially takes some more time.

klaytn/storage/database/db_manager.go

Line 749 in 5b050ee

dbm.setStateTrieMigrationStatus(0)

If the node stops or kills Klaytn process just after finishing the state migration, the old database will not be removed. Even a user can encounter a more complicated situation that the migration is done but the new database isn't set to a main state trie database.

Mitigation
The status of state migration should be converted after removing the old database.

[exalate-issue-sync]

Exalate commented: Issue Created by: aidan-kwon