Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darwin L1 Data Cache fix #122

Merged
merged 2 commits into from Nov 8, 2022
Merged

Darwin L1 Data Cache fix #122

merged 2 commits into from Nov 8, 2022

Conversation

ironiridis
Copy link
Contributor

It appears there was a copy-paste error when implementing the L1 icache and dcache detection for Apple's silicon. This PR includes a test that detects the discrepancy and the fix.

Fixes #121

Check that the struct members for the L1 cache match the values provided by the OS sysctl utility
@ironiridis
Copy link
Contributor Author

@klauspost For your review, per your comment.

Copy link
Owner

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good. Thanks for the contribution.

@klauspost klauspost merged commit 1061e99 into klauspost:master Nov 8, 2022
@ironiridis ironiridis deleted the darwin-l1dcache-fix branch November 8, 2022 17:12
kodiakhq bot pushed a commit to cloudquery/filetypes that referenced this pull request Apr 1, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/klauspost/cpuid/v2](https://togithub.com/klauspost/cpuid) | indirect | minor | `v2.1.0` -> `v2.2.4` |

---

### ⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.

---

### Release Notes

<details>
<summary>klauspost/cpuid</summary>

### [`v2.2.4`](https://togithub.com/klauspost/cpuid/releases/tag/v2.2.4)

[Compare Source](https://togithub.com/klauspost/cpuid/compare/v2.2.3...v2.2.4)

#### What's Changed

-   Add more Intel mitigation flags by [@&#8203;klauspost](https://togithub.com/klauspost) in [klauspost/cpuid#128
-   Add more Intel Sierra Forest instructions by [@&#8203;fmuyassarov](https://togithub.com/fmuyassarov) in [klauspost/cpuid#129

**Full Changelog**: klauspost/cpuid@v2.2.3...v2.2.4

### [`v2.2.3`](https://togithub.com/klauspost/cpuid/releases/tag/v2.2.3)

[Compare Source](https://togithub.com/klauspost/cpuid/compare/v2.2.2...v2.2.3)

#### What's Changed

-   docs: add homebrew installation note by [@&#8203;chenrui333](https://togithub.com/chenrui333) in [klauspost/cpuid#126
-   Add Intel Sierra Forest instructions by [@&#8203;fmuyassarov](https://togithub.com/fmuyassarov) in [klauspost/cpuid#127

#### New Contributors

-   [@&#8203;chenrui333](https://togithub.com/chenrui333) made their first contribution in [klauspost/cpuid#126

**Full Changelog**: klauspost/cpuid@v2.2.2...v2.2.3

### [`v2.2.2`](https://togithub.com/klauspost/cpuid/releases/tag/v2.2.2)

[Compare Source](https://togithub.com/klauspost/cpuid/compare/v2.2.1...v2.2.2)

#### What's Changed

-   Add Intel Granite Rapid features by [@&#8203;fmuyassarov](https://togithub.com/fmuyassarov) in [klauspost/cpuid#125

#### New Contributors

-   [@&#8203;fmuyassarov](https://togithub.com/fmuyassarov) made their first contribution in [klauspost/cpuid#125

**Full Changelog**: klauspost/cpuid@v2.2.1...v2.2.2

### [`v2.2.1`](https://togithub.com/klauspost/cpuid/releases/tag/v2.2.1)

[Compare Source](https://togithub.com/klauspost/cpuid/compare/v2.2.0...v2.2.1)

#### What's Changed

-   Add more AMD flags by [@&#8203;klauspost](https://togithub.com/klauspost) in [klauspost/cpuid#123
-   Fix microarch level by [@&#8203;klauspost](https://togithub.com/klauspost) in [klauspost/cpuid#124

**Full Changelog**: klauspost/cpuid@v2.2.0...v2.2.1

### [`v2.2.0`](https://togithub.com/klauspost/cpuid/releases/tag/v2.2.0)

[Compare Source](https://togithub.com/klauspost/cpuid/compare/v2.1.2...v2.2.0)

#### What's Changed

-   Add CombineFeatures for faster lookups. by [@&#8203;klauspost](https://togithub.com/klauspost) in [klauspost/cpuid#120
-   Darwin L1 Data Cache fix by [@&#8203;ironiridis](https://togithub.com/ironiridis) in [klauspost/cpuid#122

#### New Contributors

-   [@&#8203;ironiridis](https://togithub.com/ironiridis) made their first contribution in [klauspost/cpuid#122

**Full Changelog**: klauspost/cpuid@v2.1.2...v2.2.0

### [`v2.1.2`](https://togithub.com/klauspost/cpuid/releases/tag/v2.1.2)

[Compare Source](https://togithub.com/klauspost/cpuid/compare/v2.1.1...v2.1.2)

#### What's Changed

-   Add some Intel flags by [@&#8203;klauspost](https://togithub.com/klauspost) in [klauspost/cpuid#119

**Full Changelog**: klauspost/cpuid@v2.1.1...v2.1.2

### [`v2.1.1`](https://togithub.com/klauspost/cpuid/releases/tag/v2.1.1)

[Compare Source](https://togithub.com/klauspost/cpuid/compare/v2.1.0...v2.1.1)

#### What's Changed

-   Add CPU Stepping by [@&#8203;klauspost](https://togithub.com/klauspost) in [klauspost/cpuid#112
-   Code consistency by [@&#8203;fpelliccioni](https://togithub.com/fpelliccioni) in [klauspost/cpuid#114
-   Remove SCE by [@&#8203;klauspost](https://togithub.com/klauspost) in [klauspost/cpuid#115
-   Fixes MMXEXT by [@&#8203;fpelliccioni](https://togithub.com/fpelliccioni) in [klauspost/cpuid#116
-   Skip AMD leaf 0x8000001d parsing if no TOPEXT by [@&#8203;klauspost](https://togithub.com/klauspost) in [klauspost/cpuid#118

#### New Contributors

-   [@&#8203;fpelliccioni](https://togithub.com/fpelliccioni) made their first contribution in [klauspost/cpuid#114

**Full Changelog**: klauspost/cpuid@v2.1.0...v2.1.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 3am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTQuMCIsInVwZGF0ZWRJblZlciI6IjM0LjE1NC4wIn0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

L1 icache and dcache on M1 are the same sysctl
2 participants