zstd: Improve throughput of SpeedBestCompression encoder #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lifted ofCode and mlCode computations out of match.estBits, so that method will be inlined into its only caller. Also some changes to eliminate a branch: the last if block becomes two CMOVs/CSELs on amd64 and arm64. name old speed new speed delta Encoder_EncodeAllSimple/best-8 11.1MB/s ± 1% 16.9MB/s ± 1% +52.23% (p=0.000 n=10+10) Encoder_EncodeAllSimple4K/best-8 8.41MB/s ± 1% 10.95MB/s ± 0% +30.20% (p=0.000 n=10+10) name old alloc/op new alloc/op delta Encoder_EncodeAllSimple/best-8 20.0B ± 0% 18.0B ± 0% -10.00% (p=0.002 n=8+10) Encoder_EncodeAllSimple4K/best-8 2.00B ± 0% 2.00B ± 0% ~ (all equal)
greatroar
added a commit
to greatroar/compress
that referenced
this pull request
Nov 26, 2022
This reverts commit 2878205. Turns out that the speedup was due to a bug. In: offset := uint32(m.rep) if offset < 0 { offset = uint32(m.s-m.offset) + 3 } offset is never < 0 because it's cast to uint32 too early.
klauspost
pushed a commit
that referenced
this pull request
Nov 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lifted ofCode and mlCode computations out of match.estBits, so that method will be inlined into its only caller. Also some changes to eliminate a branch: the last if block becomes two CMOVs/CSELs on amd64 and arm64.